Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation() data loading fails if definitions.h doesn't exist #2

Closed
Simske opened this issue Dec 18, 2020 · 2 comments
Closed

Simulation() data loading fails if definitions.h doesn't exist #2

Simske opened this issue Dec 18, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Simske
Copy link
Owner

Simske commented Dec 18, 2020

definitions.h is loaded to find the type of coordinate system. It should fall back to the default if the file doesn't exist.

@Simske Simske changed the title Simulation() initialization fails if definitions.h doesn't exist Simulation() data loading fails if definitions.h doesn't exist Dec 18, 2020
@Simske
Copy link
Owner Author

Simske commented Dec 18, 2020

Type of coordinate system could also be loaded from gridfile header, maybe the better option.
Example:

# ******************************************************
# PLUTO 4.3 Grid File
# Generated on  Fri Dec 18 17:17:18 2020
# 
# DIMENSIONS: 2
# GEOMETRY:   POLAR
# X1: [ 0.400000,  2.500000], 256 point(s), 2 ghosts
# X2: [ 0.000000,  6.283185], 768 point(s), 2 ghosts
# ******************************************************

@Simske Simske added the bug Something isn't working label Dec 18, 2020
@Simske Simske closed this as completed in d993330 Dec 21, 2020
@Simske
Copy link
Owner Author

Simske commented Dec 21, 2020

Fixed with above suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant