PVS-Studio bugs

[jacob1]

Looks like they used us as an example, mniip found it but didn't ping me, so then savask found it. All these fail bugs and warnings should be fixed sometime: http://www.viva64.com/en/b/0298/ . We shouldn't be famous just for having such buggy code :P.

And speaking of warnings I was going through and fixing many warnings, never finished since it would probably take hours ... but after I do finish we should probably compile with warnings enabled so that they don't pile up again.

[Departing]

Sounds like a plan!

[mniip]

savask found it

http://mniip.com/irc/log/?channel=~powder&head=2014.12.24-12%3A07%3A58&tail=2014.12.24-12%3A07%3A59

[jacksonmj]

A selection of these have been fixed in 236ff08

cppcheck gives a few hundred more things to look at though... https://gist.github.com/jacksonmj/efb4b6caa667b0bbfd3a

[jacob1]

All the PVS-Studio bugs are fixed now at least. Not the cppcheck ones though. Not sure what the command to get that output is exactly ... when I ran it I got a ton of warnings (mostly things which aren't likely to cause bugs).