subscriptions key validation

[Eth3rnit3]

Hello, first of all, I wanted to impregnate you for the work you've done. I just implemented this gem in a very big application, even if it took me 2 days, thanks to you, I gained a lot more!

I was able to easily implement slack as well as other notification thanks to base and everything works very well.

There's still something I don't understand or that I had to do wrong, but I don't understand why when a user save his subscription for a given key for example message.reply then no other user can subscribe to this key, and those because of this validation

activity_notification/lib/activity_notification/orm/mongoid/subscription.rb

Line 31 in 3dc335d

validates :key, presence: true, uniqueness: { scope: :target }

pry(main)> a.find_or_create_subscription('message.reply').subscribe
=> true

pry(main)> b.find_or_create_subscription('message.reply').subscribe
ActivityNotification::RecordInvalidError: Key est déjà pris.
from /Users/eth3rnit3/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/activity_notification-2.1.1/lib/activity_notification/models/concerns/subscriber.rb:53:in `create_subscription'

I think that each user can subscribe to the same key no?

[sebfie]

@simukappu I also have this issue !

[Eth3rnit3]

I can give you more information about the problem...
it's probably related to mongoid

I can solve my problem by replacing the :target of this line

activity_notification/lib/activity_notification/orm/mongoid/subscription.rb

Line 31 in 86e4da6

validates :key, presence: true, uniqueness: { scope: :target }

by :target_id

[simukappu]

I've recognized this mongoid subscription bug from v2.1.0. Thank you for your feedback!

[Eth3rnit3]

gladly

[simukappu]

Confirmed and merged your pull request #128. Thank you!

[Eth3rnit3]

Thank you!

[simukappu]

Just released as v2.1.2. Thank you for your contribution!