Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TrajectoryData in converter tests #134

Open
blairlyons opened this issue Nov 10, 2022 · 0 comments
Open

Use TrajectoryData in converter tests #134

blairlyons opened this issue Nov 10, 2022 · 0 comments
Labels
maintenance Code cleanup/refactoring, test coverage, etc.

Comments

@blairlyons
Copy link
Contributor

What needs to happen?

Currently most converter tests call JsonWriter.format_trajectory_data(trajectory_data) and then verify the data in dict format. Ideally we want the converter tests to not involve JsonWriter, so we could instead:

  • in converter tests, test that the TrajectoryData object is correct while still a custom Python object (i.e. just use trajectory_data rather than first converting it to dict with JsonWriter.format_trajectory_data(trajectory_data)
  • make separate tests for all the Writers' format_trajectory_data(...) functions

Why should we do this?

So tests are more modular and different objects are tested separately

When does this need to get done?

2023

@blairlyons blairlyons added the maintenance Code cleanup/refactoring, test coverage, etc. label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code cleanup/refactoring, test coverage, etc.
Projects
Status: 🌳 Backlog
Development

No branches or pull requests

1 participant