Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site broken when LocalStorage not working #72

Open
sinak opened this issue Jul 28, 2015 · 3 comments
Open

Site broken when LocalStorage not working #72

sinak opened this issue Jul 28, 2015 · 3 comments

Comments

@sinak
Copy link
Owner

sinak commented Jul 28, 2015

This is happening in Safari Private Browsing mode on mobile and desktop:

image

@sinak
Copy link
Owner Author

sinak commented Jul 28, 2015

I tried fixing this by adding this code block in place of line 11 in address-form.js:

  if (typeof dioData.getCanonicalAddress() !== 'undefined' ) {
    var priorCanonicalAddress = dioData.getCanonicalAddress().components;
  }
  else {
    var priorCanonicalAddress = {};
  }

But that causes this error:

Error: [angular-locker] The browser does not support localStorage

According to this Safari doesn't support localStorage in private mode on desktop or mobile.

I think we should update the app to default to session cookies of localStorage isn't available. @l12s would you be okay with implementing this?

@sinak sinak changed the title Site broken in Safari Private Browsing mode Site broken when LocalStorage not working Jul 28, 2015
@sinak sinak assigned ghost Jul 28, 2015
@ghost
Copy link

ghost commented Sep 28, 2015

You can't use a session cookie as the response data size is too high. We can default to simply using an object in memory though.

@sinak
Copy link
Owner Author

sinak commented Jan 22, 2017

We should consider just throwing up a warning if we don't have time get this fixed.

@mfb mfb unassigned ghost Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants