Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting into multiple files / app structure #3

Closed
cschneid opened this issue Sep 2, 2010 · 8 comments
Closed

Splitting into multiple files / app structure #3

cschneid opened this issue Sep 2, 2010 · 8 comments

Comments

@cschneid
Copy link
Member

cschneid commented Sep 2, 2010

No description provided.

@zzak
Copy link
Member

zzak commented Sep 2, 2010

I would like to take this on, if noone else minds.

Will report my progress tonight.

@cschneid
Copy link
Member Author

cschneid commented Sep 2, 2010

Sweet - shoot me pull requests. Skim over the README for style guide (80 column lines, etc), and make sure the book builds.

@zzak
Copy link
Member

zzak commented Sep 2, 2010

Will do, should I make pulls to sinatra/sinatra-book or cschneid/sinatra-book?

@cschneid
Copy link
Member Author

cschneid commented Sep 2, 2010

I am doing my work here, but cschneid/sinatra-book is a mirror and up-to-date.

Stick to sinatra's copy for now.

@zzak
Copy link
Member

zzak commented Sep 2, 2010

Alright, I will make a new branch on my fork to start making changes.

@zzak
Copy link
Member

zzak commented Sep 3, 2010

Just wanted to report my findings from last night on here:

We can get the book to build into separate html files fairly easily, but there will need to be modifications made to the TOC (so the anchor links are properly updated). Currently when thor builds the book it reads each line from book-order.txt and stuffs everything into one big string. We would have to modify this as well, or create a new method for building the site, that would instead create separate keys for each line, values being the file parsed to html from the markdown files.

However, I think we agreed last night that this might not be necessary just yet, as the book isn't that long; after all there is a table of contents to scan the book and there's always CTRL+F..

@rkh
Copy link
Member

rkh commented Oct 29, 2010

Are you aware of http://www.humbug.in/docs/sinatra-book/?

@zzak
Copy link
Member

zzak commented Feb 25, 2011

Closing this, sinatra-book-contrib will handle excess recipes and the book can focus on a more concise, selection, of recipes

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants