Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deprecate Sinatra::Default; use Sinatra::Application [#240]
- Loading branch information
Showing
2 changed files
with
13 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f5d4df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to produce a deprecation warning for people still using Default?
class Default < Application
def initialize(app = nil)
puts "WARNING: Sinatra::Default is deprecated and will be removed in future versions. Please use Sinatra::Application from now on."
super(app)
end
end
7f5d4df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, forgot to tab it. ;)