Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD support #10

Closed
fox1t opened this issue Mar 9, 2020 · 4 comments · Fixed by #11
Closed

CI/CD support #10

fox1t opened this issue Mar 9, 2020 · 4 comments · Fixed by #11

Comments

@fox1t
Copy link
Contributor

fox1t commented Mar 9, 2020

Hi @sinclairzx81 we at HospitalRun decided to base our data and db validation structure upon this library.

Would you mind if we make a PR to typebox to add GitHub actions for building and testing it automatically?

In addition to that, if you like also other automation as Coveralls or auto publish on npm just ping us.

@sinclairzx81
Copy link
Owner

Hi, glad to hear TypeBox is getting put to good use :) Also, thanks for the offer !

I have configured TypeBox for Travis CI which automatically builds and tests on commits, but could be interested in moving to GitHub Actions if its generally preferred these days. I haven't used GitHub Actions before, but bringing CI closer to the repository sounds like a good idea. Do you have any pre-configured repository i could take a look at?

As for auto npm publishing, I'm ok manually publishing for the time being. Perhaps when TypeBox gets to a 1.0.0 release I may look into it then.

Many Thanks
S

@fox1t
Copy link
Contributor Author

fox1t commented Mar 10, 2020

Of course we have. We usually have configured an action on every PR and every merge to master. Additionally we have also configured auto release on some repos.
This one is for PR https://github.com/HospitalRun/hospitalrun-frontend/actions/runs/53028945
This is the configuration that we use: https://github.com/HospitalRun/hospitalrun-frontend/tree/master/.github/workflows

As I said we can make a PR to this project to add support only for the run on PR (so you can be sure that new contributors doesn't break anything) and on push/merge on master, since it is important for releases.

@sinclairzx81
Copy link
Owner

Hi, that looks great. Would appreciate the PR ! I'll retire the Travis CI back end once you're able submit it through.

Many Thanks!
S

@sinclairzx81
Copy link
Owner

@fox1t @tehkapa Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants