Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Dominant Colors of Image doesn’t get accurate colours. #214

Closed
raikesy opened this issue Jan 7, 2024 · 3 comments
Closed

Get Dominant Colors of Image doesn’t get accurate colours. #214

raikesy opened this issue Jan 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@raikesy
Copy link

raikesy commented Jan 7, 2024

Description

Unrelated to the list order bug affecting this action, the colours returned by this action appear to be more faded/pastel versions of the actual colours in the image. I have created a shortcut that demonstrates this when using a Home Screen screenshot as input.

Not sure if related but the action doesn’t always pick up every colour, for example it doesn’t return the white colour in several of the icons in the attached output.
Image

macOS/iOS version

17.2.1

Shortcut URL

https://www.icloud.com/shortcuts/699a34a04f3e4f869ec91813c0f18d10

@raikesy raikesy added the bug Something isn't working label Jan 7, 2024
@sindresorhus
Copy link
Owner

Can you try out the latest TestFlight build (62) and let me know whether it improves it? It's using a new algorithm for getting the dominant color.

https://testflight.apple.com/join/fJGUrsZx

@raikesy
Copy link
Author

raikesy commented Jan 10, 2024

Seems to be a significant improvement:
Image

But still a couple of odd results (Trainline, lebara).

@sindresorhus
Copy link
Owner

Are you sure the problem is not your shortcut?

I tried getting the dominant color for the Trainline icon alone and it works fine for me.

Screenshot 2024-01-11 at 02 35 00 Screenshot 2024-01-11 at 02 32 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants