Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getOpenWindows does not return all windows #157

Closed
nsharma1396 opened this issue Dec 28, 2022 · 6 comments · Fixed by #159
Closed

getOpenWindows does not return all windows #157

nsharma1396 opened this issue Dec 28, 2022 · 6 comments · Fixed by #159

Comments

@nsharma1396
Copy link

nsharma1396 commented Dec 28, 2022

Thanks for the amazing work on this package

I am trying to use getOpenWindows and though it does returns the active windows, few cases seems to get missed:

  • Chrome/firefox tabs: Only the current focused chrome or firefox tab is returned instead of all open tabs (same for apps that have tabs like powershell, vscode, etc)
  • Widget kind of windows are only returned in the activeWindow API and not the getOpenWindows one

Not sure if this is expected out of the API but would really appreciate if there can be some workaround for this.

Thanks

@sindresorhus
Copy link
Owner

Chrome/firefox tabs: Only the current focused chrome or firefox tab is returned instead of all open tabs (same for apps that have tabs like powershell, vscode, etc)

Tabs are not windows, so this is expected behavior.

Widget kind of windows are only returned in the activeWindow API and not the getOpenWindows one

What are "widget windows"? And what OS?

@nsharma1396
Copy link
Author

Tabs are not windows, so this is expected behavior.

Okay, that makes sense, but is there any way that can help us get all the tabs as well?

What are "widget windows"? And what OS?

So, by hitting the Win key + W in Windows 11, you can bring up the widgets board. I was referring to that but I think that doesn't really qualify as a window again so that's alright.

@sindresorhus
Copy link
Owner

Okay, that makes sense, but is there any way that can help us get all the tabs as well?

I'm not familiar with Windows, so I don't know whether it's possible. It feels a bit outside the scope of this package though.

So, by hitting the Win key + W in Windows 11, you can bring up the widgets board. I was referring to that but I think that doesn't really qualify as a window again so that's alright.

It's a bug that it's included.

// @miniben-90

miniben-90 added a commit to miniben-90/active-win that referenced this issue Dec 30, 2022
…openWindows

Solving issue sindresorhus#157 with active widgets and openWindows function.
@RedSparr0w
Copy link

It seems that most fullscreen/fullscreen windowed windows are also excluded.

@RedSparr0w
Copy link

RedSparr0w commented Jan 11, 2023

Just checking, did #159 also solve the issue of fullscreen windows not being detected?

Or should I open a new issue?

@sindresorhus
Copy link
Owner

@RedSparr0w Open a new issue about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants