Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and release process question #167

Closed
wrgoto opened this issue May 5, 2023 · 3 comments
Closed

Build and release process question #167

wrgoto opened this issue May 5, 2023 · 3 comments

Comments

@wrgoto
Copy link
Contributor

wrgoto commented May 5, 2023

Hey @sindresorhus, thanks for maintaining such a great library. What are the steps to build and publish the newest version? We're trying to build from our fork and have some questions. I see that when you create a release, GitHub Actions builds the Windows binaries. Do you build the macOS locally, add the Windows binaries to lib/binding and then publish?

@sindresorhus
Copy link
Owner

The macOS binary is built at publish time: https://github.com/sindresorhus/active-win/blob/27221e5da0a64025bdec8759605694ea84ff9f68/package.json#L38

The Windows binaries are built with GitHub Actions and automatically added to the GitHub release: https://github.com/sindresorhus/active-win/blob/main/.github/workflows/release.yml

@wrgoto
Copy link
Contributor Author

wrgoto commented May 5, 2023

@sindresorhus Why aren't you adding the macOS binaries to the GitHub release?

@sindresorhus
Copy link
Owner

For simplicity. It's easier to just embed it in the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants