Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ffi-napi instead of ffi to support ABI 64 #30

Closed
ljubic opened this issue Oct 26, 2018 · 2 comments
Closed

Add ffi-napi instead of ffi to support ABI 64 #30

ljubic opened this issue Oct 26, 2018 · 2 comments
Labels
enhancement help wanted

Comments

@ljubic
Copy link
Contributor

ljubic commented Oct 26, 2018 •
edited

The ffi module cannot be compiled when ABI 64 is used. The solution to this is to replace ffi with ffi-napi which has the same api.
@sindresorhus
Copy link
Owner

PR welcome :)

@ljubic
Copy link
Contributor Author

ljubic commented Oct 27, 2018

@sindresorhus I tested the changes using npm run test and both passed.
Here is the PR:
#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @ljubic