-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Windows information without FFI #35
Comments
The script I was looking at: https://gallery.technet.microsoft.com/scriptcenter/Get-the-position-of-a-c91a5f1f |
I’m happy to add support for a fallback, but anything other than native will be very slow, especially powershell. One day Node.js will have native FFI support and all will be good. |
Cool, I was thinking of this as a fallback, specifically for vscode plugins where I can't compile. Well send a PR in the next few days. |
I ended up creating a big fork, and I'm not sure if it makes sense to merge in. The biggest changes:
|
@arciisine Totally up to you. I'm happy to add you as a maintainer if you would like to maintain it here. Alternatively, we could add a link in the readme to your fork. |
@sindresorhus I think I'm going to fork for now, given the magnitude of change. I want to make sure I have proper attribution, beyond the MIT license inclusion. Is there anything specifically you would want to see regarding acknowledgement/attribution? |
That's totally fine.
Just ensure you have proper MIT license inclusion. |
Do a PR with a link to your fork when it's out. Should be added here: https://github.com/sindresorhus/active-win#related |
I'm currently using this module in a vscode plugin, and platform specific binaries are complicated to handle. I was looking at some powershell scripts what should be able to produce the necessary information, and was wondering if you would be open to a PR that removed the use of ffi.
The text was updated successfully, but these errors were encountered: