Fix #32 - MacOS crash when Desktop becomes the active window

[uglow]

Fixes #32.

The Desktop window does not appear in the window collection because of the excludeDesktopElements flag - which is reasonable as you probably don't want icons and the System menu showing up in the results. However, this causes the crash that was identified in issue #32.

This PR prevents the system from crashing out when the active window is not in the window collection by return a "fake" Desktop result.

[uglow]

@sindresorhus Good to merge?

[matthewjumpsoffbuildings]

im having this issue too, hoping this fixes it

[uglow]

@tiangolo @sindresorhus - are you able to review and merge, please?

[sindresorhus]

If we go with this solution, you have to fill out all the fields.

[sindresorhus]

I think a better solution would be to admit that there can't always be an active window, and return null in such scenarios.

[uglow]

If we return null it would be a (more) breaking change than this PR. But I don’t mind.

[sindresorhus]

I'm ok with that.

[matthewjumpsoffbuildings]

i also think returning null is fine, its easy enough to modify code to check if null

watever happens, as long as it doesnt break if you are lookin at the desktop on macOS im happy ;)

[uglow]

Updated to return null. Works locally when calling sleep 5 && ./main. Added test to demonstrate that JSON.parse('null') returns null (ie. retuning 'null' doesn't break the JSON parser).

[uglow]

@sindresorhus Good to merge?

[uglow]

Btw, I've just created a tool called active-win-log (link) which uses this package to create a usage log. I'm using it to help me keep track of time spent on projects when working remotely. Thanks for writing this package! 👍🏻

[sindresorhus]

@uglow Cool use-case. You should do a PR to add it to the readm here. Under a new "Users" section or something ;)