-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform
field to Result
, add TypeScript definition
#40
Add platform
field to Result
, add TypeScript definition
#40
Conversation
Why are you adding a platform field? Users can just check |
It's for the discriminated union type in TypeScript to work correctly. This way, no null checks are needed, just a check for a platform. You can take a look at the TS tests, its visible there. |
Ah, I see. So there's no way of doing this with the |
platform
field to Result
, add TypeScript definitionplatform
field to Result
, add TypeScript definition
@BendingBender This still has |
|
platform
field to Result
, add TypeScript definitionplatform
field to Result
, add TypeScript definition
Can you update this to use CommonJS-compatible syntax? Also needs to be updated for f06f7e3 |
|
platform
field to Result
, add TypeScript definitionplatform
field to Result
, add TypeScript definition
platform
field to Result
, add TypeScript definitionplatform
field to Result
, add TypeScript definition
Waiting for tsdjs/tsd#19