Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node.js 12 compatibility #58

Merged
merged 2 commits into from Sep 26, 2019
Merged

Fix Node.js 12 compatibility #58

merged 2 commits into from Sep 26, 2019

Conversation

Janealter
Copy link
Contributor

No description provided.

@Janealter Janealter changed the title Replace ref by ref napi Replace ref by ref-napi Sep 26, 2019
@Janealter Janealter mentioned this pull request Sep 26, 2019
Closed
albinekb
albinekb approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can test this on macOS if you think it's needed?

@Janealter
Copy link
Contributor Author

Janealter commented Sep 26, 2019 •
edited

Thanks! I can test this on macOS if you think it's needed?

I think it's needed, I tested only on Windows.
UPD: But i did't change code for MacOS, so there should be no problems.

@sindresorhus sindresorhus changed the title Replace ref by ref-napi Fix Node.js 12 compatibility Sep 26, 2019
@sindresorhus sindresorhus merged commit 659e1a5 into sindresorhus:master Sep 26, 2019
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinekb albinekb albinekb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Janealter @sindresorhus @albinekb