Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Electron 8 #70

Closed
wants to merge 1 commit into from
Closed

Update for Electron 8 #70

wants to merge 1 commit into from

Conversation

wgcv
Copy link

@wgcv wgcv commented Apr 28, 2020

Fixes #68 solved by: @timsu

@sindresorhus
Copy link
Owner

Can you open an issue on ref-napi or Electron?

@johndalangin
Copy link

johndalangin commented May 6, 2020

Hi @sindresorhus

Confirming that this PR indeed fixes the Electron 8. Would there be any concerns to consider before merging this?

Thank you and stay safe.

@sindresorhus
Copy link
Owner

Yes, when someone does what I commented above. I'm not going to merge a workaround without knowing that it's reported so it can be fixed in the future and the workaround can be reverted.

@sindresorhus sindresorhus changed the title Update for electron 8 Update for Electron 8 May 6, 2020
@johndalangin
Copy link

Understood thanks 🙏

@srsholmes
Copy link

@johndalangin @wgcv @timsu Any update on the request of "Can you open an issue on ref-napi or Electron?"

I'm happy to open the issue, but dont want to duplicate it. Also I dont exactly know what the issue was and how it was solved. It would be good to get this merged when the issue has been opened.

@wgcv
Copy link
Author

wgcv commented Jun 18, 2020

I didn't open a issue.

@johndalangin
Copy link

@srsholmes I also didn't open an issue as I have limited understanding of the specifics at the moment to credibly open one.

@sindresorhus
Copy link
Owner

#68 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

active-win working in electron 7 but not in electron 8
4 participants