Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just use rxjs-minimal instead of both rxjs-full and minimal #3

Closed
jamestalmage opened this issue Apr 27, 2016 · 1 comment
Closed

Comments

@jamestalmage
Copy link
Contributor

jamestalmage commented Apr 27, 2016

See this comment.

RxJs uses an interesting loader mechanism that allows users to specify exactly which Observable methods are implemented. This allows them to pursue a robust API, and users don't necessarily have to pay the price with larger browserified packages. (I think you can accomplish similar with bluebird, but it requires a build step - rxjs automates feature selection via require/import statements - it's pretty cool). More details here

Anyways. I think we should probably just select the minimal install when auto-resolving. Then users can patch to get the features they want, but we aren't necessarily loading the entirety of rxjs.

@sindresorhus
Copy link
Owner

sindresorhus commented Apr 27, 2016

Agreed.

Just need to make sure to document how to get the full one:

Might be worth explaining that in the docs here, even though it's an rxjs implementation detail. Especially if we default to the minimal one over the full one. - 33293a5#commitcomment-17275070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants