Skip to content

Commit

Permalink
Close #135 PR: add failing test demonstrating long running onExit() h…
Browse files Browse the repository at this point in the history
…ook in child process. Fixes #134
  • Loading branch information
jamestalmage authored and sindresorhus committed Nov 6, 2015
1 parent 6f55d8e commit 68a51fb
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 4 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
"devDependencies": {
"coveralls": "^2.11.4",
"nyc": "^3.2.2",
"signal-exit": "^2.1.2",
"tap-dot": "^1.0.0",
"tape": "^4.0.0",
"xo": "*"
Expand Down
17 changes: 15 additions & 2 deletions test/fixture/long-running.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,25 @@
'use strict';
const test = require('../../');
var onExit = require('signal-exit');

test('long running', function (t) {
t.plan(1);

onExit(function () {
// simulate an exit hook that lasts a short while
var start = Date.now();
while(Date.now() - start < 2000) {
//synchronously wait for 2 seconds
}
process.send({name:'cleanup-completed', data: {completed: true}});
}, {alwaysLast: true});

setTimeout(function () {
t.ok(true);
});

setTimeout(function () {
// this would keep the process running for a long time.
console.log('I\'m gonna live forever!!');
}, 15000);

t.ok(true);
});
9 changes: 7 additions & 2 deletions test/fork.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,17 @@ test('rejects on error and streams output', function (t) {
});

test('exit after tests are finished', function (t) {
t.plan(1);
t.plan(2);

var start = Date.now();
var cleanupCompleted = false;

fork(fixture('long-running.js'))
.on('exit', function () {
t.ok(Date.now() - start < 10000);
t.ok(Date.now() - start < 10000, 'did NOT wait for setTimeout(fn, 15000');
t.ok(cleanupCompleted, 'did wait for onExit(fn) to complete');
})
.on('cleanup-completed', function (event) {
cleanupCompleted = event.completed;
});
});

0 comments on commit 68a51fb

Please sign in to comment.