Merge pull request #464 from sotojuan/fix-undefined-skip

Fix undefined skip count
avajs · Jan 23, 2016 · da0cce6 · da0cce6
2 parents 3f98ac1 + 24b234d
commit da0cce6
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/lib/reporters/tap.js b/lib/reporters/tap.js
@@ -66,12 +66,15 @@ TapReporter.prototype.finish = function () {
 		'',
 		'1..' + (this.api.passCount + this.api.failCount),
 		'# tests ' + (this.api.passCount + this.api.failCount),
-		'# pass ' + this.api.passCount,
-		'# skip ' + this.api.skipCount,
-		'# fail ' + (this.api.failCount + this.api.rejectionCount + this.api.exceptionCount),
-		''
+		'# pass ' + this.api.passCount
 	];
 
+	if (this.api.skipCount > 0) {
+		output.push('# skip ' + this.api.skipCount);
+	}
+
+	output.push('# fail ' + (this.api.failCount + this.api.rejectionCount + this.api.exceptionCount), '');
+
 	return output.join('\n');
 };
 

diff --git a/test/reporters/tap.js b/test/reporters/tap.js
@@ -102,3 +102,29 @@ test('results', function (t) {
 	t.is(actualOutput, expectedOutput);
 	t.end();
 });
+
+test('results does not show skipped tests if there are none', function (t) {
+	var reporter = tapReporter();
+	var api = {
+		passCount: 1,
+		failCount: 2,
+		skipCount: 0,
+		rejectionCount: 3,
+		exceptionCount: 4
+	};
+
+	reporter.api = api;
+
+	var actualOutput = reporter.finish();
+	var expectedOutput = [
+		'',
+		'1..' + (api.passCount + api.failCount),
+		'# tests ' + (api.passCount + api.failCount),
+		'# pass ' + api.passCount,
+		'# fail ' + (api.failCount + api.rejectionCount + api.exceptionCount),
+		''
+	].join('\n');
+
+	t.is(actualOutput, expectedOutput);
+	t.end();
+});