Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emoji or image after the entry description #60

Closed
sindresorhus opened this issue Feb 26, 2019 · 6 comments · Fixed by #66
Closed

Allow emoji or image after the entry description #60

sindresorhus opened this issue Feb 26, 2019 · 6 comments · Fixed by #66
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Feb 26, 2019

Issuehunt badges

- [Title](URL) - Description. ⭐

or

- [Title](URL) - Description. ![](image.png)

or

- [Title](URL) - Description. <img src="image.png">

chinesedfan earned $40.00 by resolving this issue!

@carlosperate
Copy link

Not exactly the same, but related: Would you also consider allowing emoji on the section headers?

I'm using them for the following list and awesome-link doesn't seem to like it:
https://github.com/carlosperate/awesome-microbit/blob/8ca8945004d1122c7b457118ba1775e5b4cd296d/README.md

From https://travis-ci.org/carlosperate/awesome-microbit/builds/504452716:

✖    1:1    Missing License section                                                                                                                                      remark-lint:awesome/license
  ✖    1:1    Missing or invalid Table of Contents                                                                                                                         remark-lint:awesome/toc
  ✖   16:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   23:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   24:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   25:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   26:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   27:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   28:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   29:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   30:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   31:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   32:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   33:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   34:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   35:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   36:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   37:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item
  ✖   38:3    Invalid list item link URL                                                                                                                                   remark-lint:awesome/list-item

I understand if this is outside of the scope of this project, or if perhaps this format breaks the general awesome-list rules. I personally think using these help readability (it's hard to notice different sections otherwise) and it'd be great if this format would be considered.

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@transitive-bullshit
Copy link
Collaborator

@sindresorhus what do you think of @carlosperate's proposal above? I personally think it makes things less consistent & legible.

Aside from this decision, @chinesedfan's PR looks solid.

@sindresorhus
Copy link
Owner Author

Would you also consider allowing emoji on the section headers?

No. That looks messy.

@carlosperate
Copy link

Fair enough, thank you for looking into it.

@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @chinesedfan. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants