Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom crop area #6

Closed
sindresorhus opened this issue Sep 4, 2017 · 4 comments · Fixed by #8
Closed

Custom crop area #6

sindresorhus opened this issue Sep 4, 2017 · 4 comments · Fixed by #8
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Sep 4, 2017

Issuehunt badges

Right now it just fits the screen in the middle of the image and crops there. Would be nice to put the image in a scrollview, so users could select the crop they wanted.


IssueHunt Summary

[
<
i
m
g

s
r
c

'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
0
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
1
5
8
0
8
1
7
4
?
v

4
'

a
l
t

'
s
e
r
h
i
i

l
o
n
d
a
r
'

w
i
d
t
h

2
4

h
e
i
g
h
t

2
4

s
e
r
h
i
i

l
o
n
d
a
r
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
s
e
r
h
i
i

l
o
n
d
a
r
)

h
a
s

b
e
e
n

r
e
w
a
r
d
e
d
.

Backers (Total: $80.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@carlowahlstedt
Copy link

So...it sorta does this already. When you select the image, you can place it where you want, but then it takes the image that you select and place, and further crops it when doing the blurring. So it's not super accurate and that could be what might be able to be improved here; the accuracy of what's being cropped and blurred.

@sindresorhus
Copy link
Owner Author

@carlowahlstedt Yes, I've actually removed that cropping view as it was inaccurate, as you say, and didn't actually reflect what you're ended up with, as it's not possible to control the look or width/height of that cropping view. I think a much better user interface is just allowing the user to move the image in the main editor while blurring. That way you can blur, then try to change the crop, etc, to find the best possible crop and blurriness from a photo.

@IssueHuntBot
Copy link

@IssueHunt has funded $80.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 30, 2019

@sindresorhus has rewarded $72.00 to @serhii-londar. See it on IssueHunt

  • 💰 Total deposit: $80.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $8.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants