Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding camelcase-keys to Ember.js app breaks Internet Explorer 11 #20

Closed
duncan-bayne opened this issue Feb 13, 2018 · 1 comment
Closed

Comments

@duncan-bayne
Copy link

duncan-bayne commented Feb 13, 2018

We have an Ember 2.16 application, that loads correctly on Internet Explorer 11. When we add camelcase-keys:

+++ b/frontend/package.json
@@ -29,6 +29,7 @@
     "breakpoint-sass": "^2.7.1",
     "broccoli-asset-rev": "^2.4.5",
     "broccoli-babel-transpiler": "^5.7.2",
+    "camelcase-keys": "^4.2.0",

... then the application fails to load, with the following error:

SCRIPT5009: 'define' is undefined

... but only on IE11. All other browsers we test against work fine.

@sindresorhus
Copy link
Owner

This module mainly targets Node.js, not the browser. It's up to you to transpile it with Babel if you want to use it in the browser. You can find a more detailed explanation here: sindresorhus/ama#446

If you use Webpack, check out babel-engine-plugin, which transpiles only the dependencies that needs to be transpiled.

Repository owner locked as resolved and limited conversation to collaborators Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants