Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openExternalSync is deprecated (and removed in Electron 7) #1153

Closed
AidanGG opened this issue Oct 30, 2019 · 1 comment
Closed

openExternalSync is deprecated (and removed in Electron 7) #1153

AidanGG opened this issue Oct 30, 2019 · 1 comment

Comments

@AidanGG
Copy link
Contributor

AidanGG commented Oct 30, 2019

caprine/source/index.ts

Lines 456 to 460 in d27f5af

}
shell.openExternalSync(url);
}
});

and

caprine/source/index.ts

Lines 500 to 503 in d27f5af

event.preventDefault();
shell.openExternalSync(url);
});
})();

This function is not available on Electron 7 (which will presumably be supported in the future, and is the only way to use Caprine on Arch Linux right now). I'm not asking to switch to Electron 7, but could we perhaps switch to using the asynchronous shell.openExternal instead, which returns Promise<void> since the Boolean result of openExternalSync is unused? This should restore link opening on Arch Linux.

@sindresorhus
Copy link
Owner

Repository owner deleted a comment from Saboteur777 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants