Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture webpage with device frame #26

Open
nsisodiya opened this issue May 21, 2019 · 4 comments
Open

Capture webpage with device frame #26

nsisodiya opened this issue May 21, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nsisodiya
Copy link

ref - sindresorhus/pageres#367
adding deviceFrame when capturing a screenshot.
@nsisodiya nsisodiya mentioned this issue May 21, 2019
Closed
@nsisodiya
Copy link
Author

I am able to generate the screenshot with a device frame. example.
image

Please review the code. This is work in progress.

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Sep 17, 2019
@sindresorhus
Copy link
Owner

If anyone wants to work on this, see the feedback in #27.

@fisker
Copy link
Contributor

fisker commented Sep 18, 2021

Frames https://github.com/fastlane/frameit-frames/tree/gh-pages/latest

@fisker
Copy link
Contributor

fisker commented Sep 18, 2021

Frames https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/emulated_devices/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Capture webpage with device frame nsisodiya/capture-website
3 participants
@sindresorhus @fisker @nsisodiya