Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please make isCancelled KV observable #29

Closed
klartext79 opened this issue Nov 12, 2020 · 1 comment
Closed

Please make isCancelled KV observable #29

klartext79 opened this issue Nov 12, 2020 · 1 comment

Comments

@klartext79
Copy link

klartext79 commented Nov 12, 2020 •
edited

Could you add

willChangeValue(for: \.isCancelled)

and

didChangeValue(for: \.isCancelled)

on line 367 to make isCancelled observeable. The completion onCancelled cannot be set when including in objective-c project. KVO would help to get cancelled state.

Great project!
@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/CircularProgress/releases/tag/v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @klartext79