Remove object rest operator to support Node.js 8 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a Node.js user, you're expected to upgrade minor versions of Node.j 8 for both import security fixes and feature improvements. This is nothing new. |
|
Yeah, everything you said is right, but Hyper 2 use Node.js 8.2.1 and Hyper 3 is not stable enough, so my Hyper plugin wants to keep compatibility with both Hyper 2 and Hyper 3 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object rest operator was introduced in ES2018, and was not fully supported in Node.js 8 until 8.6.0:
https://node.green/#ES2018-features-object-rest-spread-properties
Hope we can keep compatibility with all the Node.js 8 version.
We can revert this commit when we drop support of Node.js 8.