Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling the cli with no git email results in undefined being inserted #18

Closed
mainrs opened this issue Aug 5, 2020 · 1 comment · Fixed by #19
Closed

Calling the cli with no git email results in undefined being inserted #18

mainrs opened this issue Aug 5, 2020 · 1 comment · Fixed by #19
Labels
bug help wanted

Comments

@mainrs
Copy link

mainrs commented Aug 5, 2020

The undefined is super hard to spot. Maybe a better placeholder like <EMAIL> could be inserted in the case that the git call doesn't return anything useful.
@sindresorhus
Copy link
Owner

It would be better to throw an error loudly.

@brandon93s brandon93s mentioned this issue Aug 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require Node.js 10 and bug fixes brandon93s/conduct
2 participants
@sindresorhus @mainrs