Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: WriteStream.end is called twice since Node 14 #47

Closed
jopemachine opened this issue Apr 6, 2022 · 0 comments · Fixed by #48
Closed

bug: WriteStream.end is called twice since Node 14 #47

jopemachine opened this issue Apr 6, 2022 · 0 comments · Fixed by #48

Comments

@jopemachine
Copy link
Contributor

jopemachine commented Apr 6, 2022 •
edited

It seems that the writable.end callback's behavior is changed since Node 14. (and it is failing the CI)

Because writable.end callback function is called automatically, it should not be called manually.

Ref: https://nodejs.org/docs/latest-v14.x/api/stream.html#stream_writable_end_chunk_encoding_callback

2022-04-07_02-56-09
@jopemachine jopemachine mentioned this issue Apr 6, 2022
Merged
@jopemachine jopemachine changed the title WriteStream.end is called twice since Node 14 bug: WriteStream.end is called twice since Node 14 Apr 6, 2022
@jopemachine jopemachine mentioned this issue Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: WriteStream.end is called twice since Node 14
1 participant
@jopemachine