Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --verbose flag #24

Closed
fisker opened this issue Jul 9, 2021 · 6 comments · Fixed by #37
Closed

Add --verbose flag #24

fisker opened this issue Jul 9, 2021 · 6 comments · Fixed by #37

Comments

@fisker
Copy link

fisker commented Jul 9, 2021

When run del-cli on huge directory, I'd like to see the progress.

@sindresorhus
Copy link
Owner

What would it look like? Progress bar, showing each file as it's being deleted, something else?

@fisker
Copy link
Author

fisker commented Jul 9, 2021

showing each file as it's being deleted

This.

Progress bar

Not care that much.

something else?

Nope.

@sindresorhus
Copy link
Owner

sindresorhus commented Jul 9, 2021

Yeah, sounds good. We'll need to add a progress event to sindresorhus/del#133

Similar to https://github.com/sindresorhus/cpy#progress-reporting

The flag should be --verbose.

@sindresorhus sindresorhus changed the title Feature request: Add --verbose or --debug mode Add --verbose flag Jul 9, 2021
@fisker
Copy link
Author

fisker commented Jul 9, 2021

Don't you think return a generator instead of sorted array in del can have better performance? Unless we want know the length of matched files.

@sindresorhus
Copy link
Owner

Why would a generator have better performance? It has to go through all the files anyway. Unless I'm misunderstanding what you mean?

@fisker
Copy link
Author

fisker commented Jul 10, 2021

You're right, I thought it run delete after sort, never mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants