Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Lint fails on initial commit due to import/extensions #45

Closed
boranseckin opened this issue May 16, 2021 · 0 comments
Closed

Lint fails on initial commit due to import/extensions #45

boranseckin opened this issue May 16, 2021 · 0 comments

Comments

@boranseckin
Copy link

I think this is really harmless but when I first copied the template, it welcomed me with a red x sign because it did not pass the linter. Interestingly, even though it has the same files and configurations, linter does not say anything on this repository. I cannot wrap my head around why the test passes in this repository but not when I fork it or use the template.

Adding a rule to the xo's config easily solves this issue but it might be better if this is solved in the template.

Here is the output of the test where it fails and the link to the build:

> app-name@0.0.0 lint /Users/runner/work/electron/electron
> xo

Error: /Users/runner/work/electron/electron/menu.js: line 12, col 24, Error - Missing file extension for "./config" (import/extensions)
Error: /Users/runner/work/electron/electron/index.js: line 9, col 24, Error - Missing file extension for "./config" (import/extensions)
Error: /Users/runner/work/electron/electron/index.js: line 10, col 22, Error - Missing file extension for "./menu" (import/extensions)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant