Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require waring #83

Closed
liudianwei opened this issue Sep 15, 2020 · 1 comment
Closed

require waring #83

liudianwei opened this issue Sep 15, 2020 · 1 comment

Comments

@liudianwei
Copy link

there is a warning like this:
`WARNING in ./node_modules/electron-debug/index.js 108:45-58
Critical dependency: the request of a dependency is an expression
@ ./src/main/index.dev.js
@ multi ./src/main/index.dev.js ./src/main/index.js

WARNING in ./node_modules/electron-debug/index.js 109:61-74
Critical dependency: the request of a dependency is an expression
@ ./src/main/index.dev.js
@ multi ./src/main/index.dev.js ./src/main/index.js`

It is because of this
addExtensionIfInstalled('devtron', name => require(name).path); addExtensionIfInstalled('electron-react-devtools', name => require(name).path);

could we change the 'name' to a const value? Suggest author to change it. Thanks First

@sindresorhus
Copy link
Owner

This is a problem with Webpack. I would recommend opening an issue over at https://github.com/webpack/webpack/issues instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants