Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading a remote text file without extension will add a .txt extension on the downloaded file #120

Closed
LoganTann opened this issue Aug 29, 2020 · 1 comment

Comments

@LoganTann
Copy link

Hello, everything is in the title ! I'm trying to implement my own updater for my project, that downloads a file from internet then check if their hash matches between local and remote.

When i'm trying to download the file : https://url[...]/LICENSE, electron-dl will write the content into LICENSE.txt

Even if it's easy to fix that by just detecting the extension and renaming the final file, adding automatically an extension shouldn't be the correct behavior in my optinion...

@sindresorhus
Copy link
Owner

It's Electron that does this. There's no logic here to force add a .txt extension. I would recommend opening an issue on Electron instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants