Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing file extension when saveAs is true #99

Open
vaishnavravi33 opened this issue Dec 4, 2019 · 3 comments
Open

Not showing file extension when saveAs is true #99

vaishnavravi33 opened this issue Dec 4, 2019 · 3 comments

Comments

@vaishnavravi33
Copy link

vaishnavravi33 commented Dec 4, 2019

When saveAs is true then Show a dialog instead of downloading immediately. But this dialog is showing the All FIles(.) instead of download file extension.

Annotation 2019-12-04 151904

Issue 1 -
When file path from server API return "abc.XLSX" then "XLSX" should be by default selected in "Save as type" dropdown.

Issue 2-
Opened dialog show the source file full path which is security issue.
Means must show Dialog Title as "Save as" instead of source file full path.

image

@abarsov
Copy link

abarsov commented Dec 19, 2019

also Google Chrome somehow determines image type if a filename from URL doesn't have extension
(It seesms it at least set JPEG by default for such images).
It would be nice to get the same behaviour with electron-dl (and it seems it is already supported in electron-dl internally, since Save Image stores image in downloads folder with correct extension)

@oosswwaalldd
Copy link

Any solution to this? I am having the same issue on Windows, filename is being ignored.

@abarsov abarsov mentioned this issue Jul 1, 2022
@louis-cf-lin
Copy link
Contributor

As of v3.5.0, you can now specify the file type using the dialogOptions field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants