looks like it doesn't handle asar files?

[burtonator]

Just local directories? This means packaged apps won't work though...

[sindresorhus]

Have you actually tried it or are you just assuming? I'm using this module in multiple production apps with ASAR.

[burtonator]

these were questions not statements ;)

[sindresorhus]

All the Node.js fs methods are patched for ASAR in Electron and works like normal. So there's nothing special needed to support ASAR.

[customautosys]

I am facing the same problem. When my app is built using electron builder, I get a File Not Found error unless I set asar:false. It appears that when ASAR is built, app.getAppPath is returning an empty string for some strange reason.

[ibash]

@siauderman late to the game, what are you setting the directory to?

If you're setting it to the top level like: serve({ directory: '.' })

There's a bug where no path is doesn't serve index.html for app://-

// filePath = "...Contents/Resources/app.asar"
// so path.extname(filePath) === ".asar" and it serves file not found

if (resolvedPath || !path.extname(filePath) || path.extname(filePath) === '.html') {

[customautosys]

@siauderman late to the game, what are you setting the directory to?

If you're setting it to the top level like: serve({ directory: '.' })

There's a bug where no path is doesn't serve index.html for app://-

// filePath = "...Contents/Resources/app.asar"
// so path.extname(filePath) === ".asar" and it serves file not found

if (resolvedPath || !path.extname(filePath) || path.extname(filePath) === '.html') {

so instead of serve({ directory: '.' }), what should I be doing?

[ibash]

Oh, I think directory: '.' should work, made a PR that fixes it: #26

You could point your package.json to ibash/electron-serve in the meantime.