-
-
Notifications
You must be signed in to change notification settings - Fork 353
/
consistent-function-scoping.js
418 lines (405 loc) · 7.06 KB
/
consistent-function-scoping.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
import test from 'ava';
import avaRuleTester from 'eslint-ava-rule-tester';
import {outdent} from 'outdent';
import rule from '../rules/consistent-function-scoping';
const ruleTester = avaRuleTester(test, {
parserOptions: {
sourceType: 'module',
ecmaVersion: 2020,
ecmaFeatures: {
jsx: true
}
}
});
const typescriptRuleTester = avaRuleTester(test, {
parser: require.resolve('@typescript-eslint/parser')
});
const arrowError = {
ruleId: 'consistent-function-scoping',
messageId: 'ArrowFunctionExpression'
};
const functionError = {
ruleId: 'consistent-function-scoping',
messageId: 'FunctionDeclaration'
};
ruleTester.run('consistent-function-scoping', rule, {
valid: [
outdent`
function doFoo(foo) {
return foo;
}
`,
outdent`
function doFoo(foo) {
return bar;
}
`,
outdent`
const doFoo = foo => foo;
`,
outdent`
foo => foo;
`,
outdent`
function doFoo(foo) {
function doBar(bar) {
return foo + bar;
}
return foo;
}
`,
outdent`
function doFoo(foo) {
function doBar(bar) {
return foo + bar;
}
}
`,
outdent`
function doFoo(foo = 'foo') {
function doBar(bar) {
return foo + bar;
}
}
`,
outdent`
function doFoo() {
const foo = 'foo';
function doBar(bar) {
return foo + bar;
}
return foo;
}
`,
outdent`
function doFoo(foo) {
function doBar(bar) {
function doZaz(zaz) {
return foo + bar + zaz;
}
return bar;
}
return foo;
}
`,
outdent`
for (let foo = 0; foo < 1; foo++) {
function doBar(bar) {
return bar + foo;
}
}
`,
outdent`
let foo = 0;
function doFoo() {
foo = 1;
function doBar(bar) {
return foo + bar;
}
return foo;
}
`,
outdent`
const doFoo = foo => {
return foo;
}
`,
outdent`
const doFoo =
foo =>
bar =>
foo + bar;
`,
outdent`
const doFoo = () => {
return bar => bar;
}
`,
outdent`
function doFoo() {
return bar => bar;
}
`,
outdent`
const doFoo = foo => {
const doBar = bar => {
return foo + bar;
}
return foo;
}
`,
outdent`
function doFoo() {
{
const foo = 'foo';
function doBar(bar) {
return bar + foo;
}
}
}
`,
outdent`
function doFoo(foo) {
{
function doBar(bar) {
return bar;
}
}
return foo;
}
`,
outdent`
function doFoo(foo) {
function doBar(bar) {
foo.bar = bar;
}
function doZaz(zaz) {
doBar(zaz);
}
doZaz('zaz');
};
`,
outdent`
function doFoo() {
return function doBar() {};
}
`,
outdent`
function doFoo(Foo) {
function doBar() {
return new Foo();
}
return doBar;
};
`,
outdent`
function doFoo(FooComponent) {
return <FooComponent />;
}
`,
outdent`
function doFoo(FooComponent) {
function Bar() {
return <FooComponent />;
}
return Bar;
};
`,
// #391
outdent`
const enrichErrors = (packageName, cliArgs, f) => async (...args) => {
try {
return await f(...args);
} catch (error) {
error.packageName = packageName;
error.cliArgs = cliArgs;
throw error;
}
};
`,
// #391 comment https://github.com/sindresorhus/eslint-plugin-unicorn/issues/391#issuecomment-536916771
outdent`
export const canStepForward = ([X, Y]) => ([x, y]) => direction => {
switch (direction) {
case 0:
return y !== 0
case 1:
return x !== X - 1
case 2:
return y !== Y - 1
case 3:
return x !== 0
default:
throw new Error('unknown direction')
}
}
`,
// #374
outdent`
'use strict';
module.exports = function recordErrors(eventEmitter, stateArgument) {
const stateVariable = stateArgument;
function onError(error) {
stateVariable.inputError = error;
}
eventEmitter.once('error', onError);
};
`,
// #375
outdent`
module.exports = function recordErrors(eventEmitter, stateArgument) {
function onError(error) {
stateArgument.inputError = error;
}
function onError2(error) {
onError(error);
}
eventEmitter.once('error', onError2);
};
`
],
invalid: [
{
code: outdent`
function doFoo(foo) {
function doBar(bar) {
return bar;
}
return foo;
}
`,
errors: [functionError]
},
{
code: outdent`
function doFoo() {
const foo = 'foo';
function doBar(bar) {
return bar;
}
return foo;
}
`,
errors: [functionError]
},
{
code: outdent`
function doFoo() {
function doBar(bar) {
return bar;
}
}
`,
errors: [functionError]
},
{
code: outdent`
const doFoo = () => {
const doBar = bar => {
return bar;
}
}
`,
errors: [arrowError]
},
{
code: outdent`
const doFoo = () => bar => bar;
`,
errors: [arrowError]
},
{
code: outdent`
function doFoo(foo) {
function doBar(bar) {
return doBar(bar);
}
return foo;
}
`,
errors: [functionError]
},
{
code: outdent`
function doFoo(foo) {
function doBar(bar) {
return bar;
}
return doBar;
}
`,
errors: [functionError]
},
{
code: outdent`
function doFoo() {
function doBar() {}
}
`,
errors: [functionError]
},
{
code: outdent`
function doFoo(foo) {
{
{
function doBar(bar) {
return bar;
}
}
}
return foo;
}
`,
errors: [functionError]
},
{
code: outdent`
{
{
function doBar(bar) {
return bar;
}
}
}
`,
errors: [functionError]
},
{
code: outdent`
for (let foo = 0; foo < 1; foo++) {
function doBar(bar) {
return bar;
}
}
`,
errors: [functionError]
}
]
});
typescriptRuleTester.run('consistent-function-scoping', rule, {
valid: [
// #372
outdent`
type Data<T> = T extends 'error' ? Error : Record<string, unknown> | unknown[]
type Method = 'info' | 'error'
export function createLogger(name: string) {
// Two lint errors are on the next line.
const log = <T extends Method>(method: T) => (data: Data<T>) => {
try {
// eslint-disable-next-line no-console
console[method](JSON.stringify({ name, data }))
} catch (error) {
console.error(error)
}
}
return {
info: log('info'),
error: log('error'),
}
}
`,
// #372 comment https://github.com/sindresorhus/eslint-plugin-unicorn/issues/372#issuecomment-546915612
outdent`
test('it works', async function(assert) {
function assertHeader(assertions) {
for (const [key, value] of Object.entries(assertions)) {
assert.strictEqual(
native[key],
value
);
}
}
// ...
});
`,
// #372 comment https://github.com/sindresorhus/eslint-plugin-unicorn/issues/372#issuecomment-546915612
outdent`
export function a(x: number) {
const b = (y: number) => (z: number): number => x + y + z;
return b(1)(2);
}
`
],
invalid: []
});