Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on eslint-visitor-keys #1099

Closed
mainrs opened this issue Feb 13, 2021 · 1 comment · Fixed by #1100
Closed

Missing dependency on eslint-visitor-keys #1099

mainrs opened this issue Feb 13, 2021 · 1 comment · Fixed by #1100
Assignees
Labels

Comments

@mainrs
Copy link

mainrs commented Feb 13, 2021

I migrated to yarn v2 plug'n'play and I get errors about this package missing a dependency declaration.

The package misses a dependency declaration on eslint-visitor-keys, which is used inside of the rules.

I can open up a PR if you want. Since the dependency is used directly, it has to be inside of dependencies, right?

@mainrs mainrs added the bug label Feb 13, 2021
@fisker
Copy link
Collaborator

fisker commented Feb 14, 2021

Since the dependency is used directly, it has to be inside of dependencies, right?

Yes.

I can open up a PR if you want.

PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants