Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 8 compatibility #1486

Closed
2 tasks
Tracked by #379 ...
sindresorhus opened this issue Aug 15, 2021 · 2 comments · Fixed by #1488
Closed
2 tasks
Tracked by #379 ...

ESLint 8 compatibility #1486

sindresorhus opened this issue Aug 15, 2021 · 2 comments · Fixed by #1488
Assignees

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Aug 15, 2021

https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0

@sindresorhus sindresorhus pinned this issue Aug 15, 2021
@bmish
Copy link
Sponsor Contributor

bmish commented Aug 15, 2021

Also this breaking change needs to be handled in two places: https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#the-lib-entrypoint-has-been-removed

  • const baseRule = require('eslint/lib/rules/no-warning-comments');
  • import {Linter, SourceCodeFixer} from 'eslint/lib/linter/index.js';

@fisker
Copy link
Collaborator

fisker commented Aug 16, 2021

I'll work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants