Rule proposal: no-useless-ternary

[fisker]

Description

I was looking for a rule to forbid ternary that equivalent to a "logical or" expression.

The only thing I got is no-unneeded-ternary rule, it checks x ? x : 1 behind an option. Even if I set defaultAssignment: false, this rule only check identifier

Fail

foo ? foo : bar;

foo.bar ? foo.bar : foo.baz

Pass

foo || bar;

foo.bar || foo.baz;

Additional Info

We should check all expressions instead of identifiers only.

This rule is safe to fix to logical or(||), but sometimes ?? operator maybe better.

So, we may want to use the suggestions API to draw attention?

[fisker]

Missing case, not everyone enables no-negated-condition

fail

!bar ? foo : bar;

[sindresorhus]

Accepted.

[dimaMachina]

another case

foo?.bar ? foo.bar : qux

[fisker]

Should we name it prefer-logical-operator or prefer-logical-operator-over-ternary to be more specific?