Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce .replaceAll() over .replace() when the pattern has g flag #1948

Closed
fisker opened this issue Nov 7, 2022 · 3 comments · Fixed by #1965
Closed

Enforce .replaceAll() over .replace() when the pattern has g flag #1948

fisker opened this issue Nov 7, 2022 · 3 comments · Fixed by #1965
Assignees
@fisker
Labels
enhancement help wanted

Comments

@fisker
Copy link
Collaborator

fisker commented Nov 7, 2022

I believe they are the same, but use .replaceAll() has more clear intention

Fail

foo.replace(/\s/g, '')

Pass

foo.replaceAll(/\s/g, '')
foo.replace(/\s/, '')
foo.replace(" ", '')
@sindresorhus
Copy link
Owner

Accepted.

@fisker fisker self-assigned this Nov 16, 2022
@fisker fisker mentioned this issue Nov 16, 2022
Merged
@fisker fisker mentioned this issue Nov 20, 2022
Merged
1 task
@kachkaev
Copy link
Contributor

Do both foo.replaceAll(/\s/g, '') and foo.replaceAll(/\s/, '') pass? Feels like there should be one style or another everywhere.

@fisker
Copy link
Collaborator Author

fisker commented Nov 21, 2022

foo.replaceAll(/\s/, '') is a runtime error. ota-meshi/eslint-plugin-regexp#472

@fisker fisker mentioned this issue Sep 14, 2023
Closed
@Logicer16 Logicer16 mentioned this issue Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fisker fisker

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
3 participants
@sindresorhus @fisker @kachkaev