Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicorn/prefer-dataset breaks on query selector #377

Closed
yakov116 opened this issue Sep 17, 2019 · 3 comments · Fixed by #383
Closed

unicorn/prefer-dataset breaks on query selector #377

yakov116 opened this issue Sep 17, 2019 · 3 comments · Fixed by #383
Labels
bug help wanted

Comments

@yakov116
Copy link
Contributor

yakov116 commented Sep 17, 2019 •
edited 

-       document.querySelector('#tableType').setAttribute('data-AllowAccess', true);
+       undefined.dataset.AllowAccess = true;
@MrHen
Copy link
Contributor

MrHen commented Sep 18, 2019

I'm assuming that the red line is the original and the green line is the auto-fix?

@yakov116
Copy link
Contributor Author

I'm assuming that the red line is the original and the green line is the auto-fix?

Yes

@sindresorhus
Copy link
Owner

// @amedora

@amedora amedora mentioned this issue Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unicorn/prefer-dataset: Fix querySelector fixer
3 participants
@MrHen @sindresorhus @yakov116