Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of xo/no-abusive-eslint-disable via a comment #40

Closed
jamestalmage opened this issue Jun 17, 2016 · 7 comments · Fixed by #308
Closed

Allow disabling of xo/no-abusive-eslint-disable via a comment #40

jamestalmage opened this issue Jun 17, 2016 · 7 comments · Fixed by #308
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@jamestalmage
Copy link
Contributor

jamestalmage commented Jun 17, 2016

Issuehunt badges

I don't think it's possible currently.


IssueHunt Summary

[
<
i
m
g

s
r
c

'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
3
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
5
7
3
1
1
7
6
?
v

4
'

a
l
t

'
t
i
a
g
o
d
a
n
i
n
'

w
i
d
t
h

2
4

h
e
i
g
h
t

2
4

t
i
a
g
o
d
a
n
i
n
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
t
i
a
g
o
d
a
n
i
n
)

h
a
s

b
e
e
n

r
e
w
a
r
d
e
d
.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Owner

Do you have an actual need for this? Curious when you'd need to disable it.

@jamestalmage
Copy link
Contributor Author

When you copy/paste in some code that you don't want to fix.

You could add to ignore in the XO config, but that's annoying to do if you plan on deleting it eventually.

@jfmengels
Copy link
Contributor

jfmengels commented Jun 17, 2016

Hmm... I don't think it's possible currently no.
I thought that maybe starting the file with // eslint-disable-line xo/no-abusive-eslint-disable would do it, but it doesn't.

Sorry for the inconvenience 😅

How would you go to disable it without touching the config? Detect a comment containing eslint-disable* and then do nothing?

@sindresorhus
Copy link
Owner

Detect a comment containing eslint-disable* and then do nothing?

👍

@gajus
Copy link

gajus commented Aug 4, 2017

How would you go to disable it without touching the config? Detect a comment containing eslint-disable* and then do nothing?

Don't understand the suggestion.

Whats the solution here?

I've run into this a few times when dealing with 3rd party code.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 31, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 24, 2019

@sindresorhus has rewarded $36.00 to @TiagoDanin. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants