Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disscuss dir => direction replacement #460

Closed
fisker opened this issue Nov 30, 2019 · 2 comments
Closed

Disscuss dir => direction replacement #460

fisker opened this issue Nov 30, 2019 · 2 comments

Comments

@fisker
Copy link
Collaborator

fisker commented Nov 30, 2019 •
edited

I was trying to do something about prevent-abbreviations, found something interesting about dir => direction replacement,

@futpib suggested this first, #237 (comment)

@sindresorhus decided to drop it #237 (comment)

then added it again #348 (comment)

Keeping this makes dir => directory not auto-fixable
@sindresorhus
Copy link
Owner

My comment was before we started supporting combinations like sortDir, which does make sense. I don't think we should do anything about this. However, what will help a lot would be to support the ESLint suggestions API, which would let users interactively choose a fix in their editor.

@fisker
Copy link
Collaborator Author

fisker commented Dec 1, 2019

Let's do suggestions later

@fisker fisker closed this as completed Dec 1, 2019
@sindresorhus sindresorhus mentioned this issue Dec 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @fisker