Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need improve number-literal-case rule #491

Closed
fisker opened this issue Dec 27, 2019 · 1 comment · Fixed by #490
Closed

Need improve number-literal-case rule #491

fisker opened this issue Dec 27, 2019 · 1 comment · Fixed by #490

Comments

@fisker
Copy link
Collaborator

fisker commented Dec 27, 2019 •
edited

Problem:

Exponential number is not considered. 0E1 will fixed to 0e1, but 1E1 is not fixed to 1e1.

We should either check strict with /^0[box]/ or handle more cases like 1.0e+1 1.0e-1
@fisker
Copy link
Collaborator Author

fisker commented Dec 27, 2019

One more thing: should also test Numeric separator, like 0xdead_BEEF

@fisker fisker mentioned this issue Dec 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve number-literal-case rule fisker/eslint-plugin-unicorn
1 participant
@fisker