Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-error-definition still has false positive on TypeScript class property #753

Open
felixfbecker opened this issue May 27, 2020 · 1 comment
Labels

Comments

@felixfbecker
Copy link

const REV_NOT_FOUND_ERROR_NAME = 'RevNotFoundError' as const
export class RevNotFoundError extends Error {
    public readonly name = REV_NOT_FOUND_ERROR_NAME
    constructor(rev?: string) {
        super(`rev ${String(rev)} not found`)
    }
}

triggers an error from custom-error-definition, but should not.

@fisker
Copy link
Collaborator

fisker commented May 27, 2020

This rule has known issues. I'm rewriting it #680 , but don't have enough time to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants