Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should localDir look up parent directories? #372

Closed
ehmicky opened this issue Oct 5, 2019 · 1 comment
Closed

Should localDir look up parent directories? #372

ehmicky opened this issue Oct 5, 2019 · 1 comment

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Oct 5, 2019

At the moment localDir defaults to process.cwd(). This does not work when the current directory is not the package root.

Should we instead default to pkgDir() or pkgDir.sync() or (if none was found) process.cwd()?
@ehmicky
Copy link
Collaborator Author

ehmicky commented Oct 5, 2019

My bad, I realize npm-run-path actually does this by adding node_modules/.bin on all parent directories instead.

@ehmicky ehmicky closed this as completed Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehmicky