-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding command to the history #559
Comments
Hi @Edo78, By history, do you mean the shell history, e.g. the Bash REPL history? |
Yes, sorry for being too vague. I'd like the command to be added to the interactive shell history if it's possible |
Thanks for explaining. There would be a few issues with this:
That being said, I can see how this feature could be useful. However, it seems like it might be a significant effort to implement properly and while respecting Execa current design (shell-agnostic with no shell by default). Based on this, I would favor not implementing this, although I am curious to hear what @sindresorhus thinks. 🤔 Also, this can probably be implemented with a module built on top of Execa, if you're open to experiment creating one. This would help keeping Execa small and modular. |
I fully understand every and each point you made. Can you elaborate on building execa module? I'll be willing to give it a try (while learning something new) |
I am thinking of a module which would wrap Execa. I.e. the arguments and return value would be forwarded to Execa, but the module would also add the history feature. I am going to close this issue preemptively, but we can re-open it if @sindresorhus thinks the history feature is a good idea to implement in Execa itself. |
Shell history is outside the scope of what we intend to do with Execa. |
I'm wondering if it's possibile to have the executed command added to the history.
Is there an option that I can't find or it's a feature that doesn't exists (yet)?
The text was updated successfully, but these errors were encountered: