Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter typing for childProcess.all #675

Closed
ehmicky opened this issue Jan 11, 2024 · 2 comments · Fixed by #689
Closed

Stricter typing for childProcess.all #675

ehmicky opened this issue Jan 11, 2024 · 2 comments · Fixed by #689

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Jan 11, 2024

childProcess.all is currently always typed as Readable | undefined.
We could make the types stricter to make it either Readable or undefined depending on Execa's arguments. Namely, it should be undefined only if either:

  • the all option is false (the default value)
  • both the stdout and stderr option is inherit, ipc, ignore, a Node.js stream or an integer. Or an array with a single item with one of those values.
@ehmicky
Copy link
Collaborator Author

ehmicky commented Jan 13, 2024

Started at #684.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Jan 14, 2024

Finished at #689.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant