Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process streams uncaught exceptions when buffer: false is used #716

Closed
ehmicky opened this issue Jan 23, 2024 · 0 comments · Fixed by #729
Closed

Process streams uncaught exceptions when buffer: false is used #716

ehmicky opened this issue Jan 23, 2024 · 0 comments · Fixed by #729

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Jan 23, 2024

When the buffer: false option is used, any error on the child process streams creates an uncaught exception. For example, this crashes the current process:

const subprocess = execa('echo', {buffer: false, reject: false});
subprocess.stdout.destroy(new Error('test'));
await subprocess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant