Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams are not destroyed when the process exits early #763

Closed
ehmicky opened this issue Jan 31, 2024 · 0 comments · Fixed by #770
Closed

Streams are not destroyed when the process exits early #763

ehmicky opened this issue Jan 31, 2024 · 0 comments · Fixed by #770

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Jan 31, 2024

When users pass a value like a transforms, web streams, etc. to the stdin/stdout/stderr options, we create a Node.js stream under-the-hood to perform our internal piping logic.

When the process fails on spawn (e.g. the command does not exist), those internally created Node.js streams are currently not destroyed. This wastes resources, i.e. is a memory leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant